Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

feat: web-angular counter app #56

Merged
merged 26 commits into from Mar 29, 2022
Merged

feat: web-angular counter app #56

merged 26 commits into from Mar 29, 2022

Conversation

Jan-Stepien
Copy link
Contributor

Description

Angular implementation of Flutter Counter app

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

felangel
felangel suggested changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good just left a few comments lmk what you think. Also, we should create a github workflow to lint, format, and test the angular app.

@Jan-Stepien
Copy link
Contributor Author

Added testing to workflow, fixed according to linter, dont know why the ng create is not formatting code at creation...

Jan-Stepien
Jan-Stepien commented Mar 2, 2022
View reviewed changes
Copy link
Contributor Author

@Jan-Stepien Jan-Stepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed requested changes

@Jan-Stepien Jan-Stepien enabled auto-merge (squash) March 14, 2022 14:47
@Jan-Stepien
Copy link
Contributor Author

Moved platform_close to separate package @felangel

@Jan-Stepien
Copy link
Contributor Author

@felangel all changes adressed it would be great if we can approve on the PR

felangel
felangel approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now to unblock things but I would really like to revisit the platform_close approach and find an alternative that is cleaner, and doesn't involve synchronized changes in both the flutter and angular codebases

@Jan-Stepien Jan-Stepien merged commit d06440b into main Mar 29, 2022
@Jan-Stepien Jan-Stepien deleted the native_angular_counter_app branch March 29, 2022 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felangel felangel felangel approved these changes

@orestesgaolin orestesgaolin Awaiting requested review from orestesgaolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jan-Stepien @felangel