#8022 - Add explanation for test file location #8031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredEzz
requested review from
sfshaza2,
khanhnwin,
domesticmouse,
johnpryan and
atsansone
as code owners
| @@ -122,7 +145,7 @@ The `pumpWidget` method builds and renders the provided widget. | |||
| Create a `MyWidget` instance that displays "T" as the title | |||
| and "M" as the message. | |||
|
|
|||
| <?code-excerpt "test/main_step4_test.dart (main)"?> | |||
| <?code-excerpt "test/my_widget_test.dart (main)"?> | |||
There was a problem hiding this comment.
I'm curious why this change was made
There was a problem hiding this comment.
I'm not entirely sure how these file names are used, but if they're visible to the reader, I wanted it to be clear where the code in the excerpt would be located
sfshaza2
reviewed
Jan 9, 2023
There was a problem hiding this comment.
Hi @JaredEzz! We are freezing the website by end of day today. I can't land this PR because the build is failing. So, for now, I'm going to close it. Please feel free to re-open it once the website is unfrozen, but you must fix the build before it can land. Thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why: The introduction for widget testing should explain where the test file should be created as the introduction for unit testing does. See https://docs.flutter.dev/cookbook/testing/unit/introduction#2-create-a-test-file
Issues fixed by this PR (if any): Fixes #8022
Presubmit checklist