Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of nullOk from MediaQuery.of #263

Closed
BrayFlex opened this issue Nov 19, 2020 · 2 comments
Closed

Removal of nullOk from MediaQuery.of #263

BrayFlex opened this issue Nov 19, 2020 · 2 comments

Comments

@BrayFlex
Copy link

BrayFlex commented Nov 19, 2020

Flutter is removing nullOk parameter from MediaQuery.of flutter/flutter#68736
Currently it is causing an issue for me on the newest beta branch released today.

It is on line 785 of extended_image.dart

  void _updateInvertColors() {
    _invertColors = MediaQuery.of(context, nullOk: true)?.invertColors ??
        SemanticsBinding.instance.accessibilityFeatures.invertColors;
  }

propose change to:

  void _updateInvertColors() {
    _invertColors = MediaQuery.maybeOf(context)?.invertColors ??
        SemanticsBinding.instance.accessibilityFeatures.invertColors;
  }

I've created a PR here: #264

@BrayFlex
Copy link
Author

BrayFlex commented Nov 19, 2020

PR: #264

@zmtzawqlp
Copy link
Member

#258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants