Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump visibility_detector dependency version #107

Closed
adigladi opened this issue Jun 22, 2022 · 5 comments
Closed

Bump visibility_detector dependency version #107

adigladi opened this issue Jun 22, 2022 · 5 comments

Comments

@adigladi
Copy link

adigladi commented Jun 22, 2022

Hi! Currently we're getting several warnings due to this package not using the latest visibility_detector version which has upgraded their linting for flutter v3.

Example of warning:

./../../.pub-cache/hosted/pub.dartlang.org/visibility_detector-0.2.2/lib/src/visibility_detector_layer.dart:126:28: Warning: Operand of null-aware operation '?.' has type 'RendererBinding' which excludes null.

Is it possible to bump this dependency version? I'm open for putting up a PR if needed!

@zmtzawqlp
Copy link
Member

zmtzawqlp commented Jun 23, 2022

dependency_overrides:
visibility_detector: ^0.3.3

i use 0.2.2 for more people can use this package

@adigladi
Copy link
Author

Okay, thanks!

Could an option be to use LTS releases for supporting older versions, similar to how it's done here maybe?
https://github.com/tanersener/ffmpeg-kit#10-lts-releases

@zmtzawqlp
Copy link
Member

if you are in flutter 3.0.0, the version of visibility_detector will be 0.3.3 automatically

@adigladi
Copy link
Author

I'm on 3.0.1 and I need to set an explicit override to get version 0.3.3.

@zmtzawqlp
Copy link
Member

029b091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants