Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI and architecture #15

Merged
merged 26 commits into from Sep 20, 2021
Merged

Improve UI and architecture #15

merged 26 commits into from Sep 20, 2021

Conversation

nohli
Copy link
Collaborator

@nohli nohli commented Sep 18, 2021

This PR includes:

  • Removal of deprecated theme color accentColor
    (to fix the dropdown menu having a different color when updated the theme for the new Flutter version)
  • Refactoring of folder structure
  • Unified SliderTitle widget instead of individual widget methods to make the ui more consistent
  • Fine-tuning of the UI (paddings and darkmode color of top bar in drawer)
  • Update to next minor version 1.2.0

@nohli nohli requested a review from AlexV525 September 18, 2021 10:24
AlexV525
AlexV525 reviewed Sep 18, 2021
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but nit picking is coming. 😉

example/lib/main_page.dart Show resolved Hide resolved
example/lib/main_page.dart Show resolved Hide resolved
lib/src/color_picker.dart Outdated Show resolved Hide resolved
lib/src/color_picker.dart Outdated Show resolved Hide resolved
lib/src/color_picker.dart Outdated Show resolved Hide resolved
lib/src/widgets/slider_title.dart Outdated Show resolved Hide resolved
@nohli nohli requested a review from AlexV525 September 19, 2021 13:26
@nohli nohli requested a review from AlexV525 September 20, 2021 08:01
AlexV525
AlexV525 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nohli
Copy link
Collaborator Author

nohli commented Sep 20, 2021

LGTM

Great, thanks for the review!

Could you publish to pub.dev?

@nohli nohli merged commit 6fc8650 into master Sep 20, 2021
@AlexV525
Copy link
Member

Could you publish to pub.dev?

The pub publish github action should work by making a release on GitHub.

@nohli
Copy link
Collaborator Author

nohli commented Sep 20, 2021

Could you publish to pub.dev?

The pub publish github action should work by making a release on GitHub.

Great, just created a new tag/release 👍🏽

@nohli nohli deleted the improve-ui-and-architecture branch October 7, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nohli @AlexV525