Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Create JPEG images without embedded ICC profile #116

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

bcse
Copy link
Contributor

@bcse bcse commented Aug 31, 2023

UIImageJPEGRepresentation encoded image included Apple Generic RGB profile by default. But Flutter doesn't decode them with ICC profile, and the result may have slightly color shifted.

I don't find any documented way to create JPEG on iOS without embedded ICC profile. But I found that using Image I/O framework with OptimizeColorForSharing=True will not include Apple Generic RGB profile. So Flutter can display them correctly.

This pull request is using Image I/O framework to encode JPEG on iOS.

UIImageJPEGRepresentation encoded image included Apple Generic RGB profile by default. But Flutter doesn't decode them with ICC profile, and the result may have slightly color shifted. Using Image I/O framework with OptimizeColorForSharing=True will not include Apple Generic RGB profile. So Flutter can display them correctly.
@CaiJingLong CaiJingLong merged commit 93846be into fluttercandies:main Mar 22, 2024
@bcse
Copy link
Contributor Author

bcse commented Mar 27, 2024

Thank you for merging!

My fix is in image_editor_common but it seems you didn't release new version of image_editor_common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants