Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom UI / customUIBuilder #112

Closed
jtkeyva opened this issue Jul 1, 2022 · 6 comments · Fixed by #113
Closed

Custom UI / customUIBuilder #112

jtkeyva opened this issue Jul 1, 2022 · 6 comments · Fixed by #113
Labels
e: UX Improvements to user experiences. s: feature There's a feature request in this issue. s: UI This issue is related with UI or layout.

Comments

@jtkeyva
Copy link

jtkeyva commented Jul 1, 2022

Version information
N/A

Is your feature request related to a problem?

No problem, except you can't change the look/feel.

Describe the solution you'd like

A way to customize the UI and gestures. Could be as simple as cloning the foregroundBuilder into a customUIBuilder function and having an option to disable the hardcoded baked in UI. A demo theme utilizing all functions such as shootingButton, backButton, flash, switch camera, close etc would be ideal.

Describe alternatives you've considered

Forking or hacking at the source code and hardcoding the changes.

Additional context

Perhaps this decouples the "WeChat" portion so a new package name like customCameraPicker or something could also work.

@jtkeyva jtkeyva added the await investigate The issue is waiting for further investigation. label Jul 1, 2022
@jtkeyva jtkeyva changed the title Themable / Custom UI Custom UI Jul 1, 2022
@jtkeyva jtkeyva changed the title Custom UI Custom UI / customUIBuilder Jul 1, 2022
@AlexV525
Copy link
Member

AlexV525 commented Jul 1, 2022

Would a similar delegate mechanism implemented in wechat_assets_picker helps?

@jtkeyva
Copy link
Author

jtkeyva commented Jul 1, 2022

I believe so. Essentially, it would be nice to be able to control the underlying functions/methods so I can put what ever icon, image, text etc on the screen and create buttons for them. Seems like it could almost all happen in the foregroundBuilder if you opened up the methods?

@AlexV525
Copy link
Member

AlexV525 commented Jul 2, 2022

Seems like it could almost all happen in the foregroundBuilder if you opened up the methods?

The foregroundBuilder is unable to carry this much content. We'll need to create delegations for it.

@AlexV525 AlexV525 added s: UI This issue is related with UI or layout. e: UX Improvements to user experiences. s: feature There's a feature request in this issue. and removed await investigate The issue is waiting for further investigation. labels Jul 2, 2022
@jtkeyva
Copy link
Author

jtkeyva commented Jul 2, 2022

ah i see

@AlexV525
Copy link
Member

AlexV525 commented Jul 5, 2022

TBH, it's better to build from the camera package if you want a customized interface.

@jtkeyva
Copy link
Author

jtkeyva commented Jul 7, 2022

TBH, it's better to build from the camera package if you want a customized interface.

Yeah, kind of what I was thinking as well but you did a lot of the heavy lifting and came up with clever solutions to common problems. Thanks for the update :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e: UX Improvements to user experiences. s: feature There's a feature request in this issue. s: UI This issue is related with UI or layout.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants