Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use method instead of getters #19

Closed
aloisdeniel opened this issue Feb 26, 2020 · 4 comments · Fixed by #38
Closed

Use method instead of getters #19

aloisdeniel opened this issue Feb 26, 2020 · 4 comments · Fixed by #38
Assignees
Labels
enhancement New feature or request

Comments

@aloisdeniel
Copy link

aloisdeniel commented Feb 26, 2020

I would preferably used methods for instead of getters that returns a new Future.

I find it more clear that an action is triggered by calling a method in a fire and forget case. At first I thought that there were a cache of the Future.

AppReview.storeListing; // I would find `AppReview.storeListing()` more transparent on the fact that a processing is potentially triggered.
@rodydavis
Copy link
Member

Yes i will refactor on a future update!

@rodydavis rodydavis self-assigned this May 26, 2020
@rodydavis rodydavis added the enhancement New feature or request label May 26, 2020
@shinsenter
Copy link
Contributor

@aloisdeniel
This may be resolved with No #38.

@tzachov
Copy link

tzachov commented Sep 29, 2020

As far as I see this issue was not resolved.
I agree with @aloisdeniel - getters for Futures feels unnatural.

I think all of these getters should be methods:

AppReview.isRequestReviewAvailable
AppReview.requestReview
AppReview.writeReview
AppReview.storeListing
AppReview.getAppID
AppReview.getiOSAppID

@rodydavis
Copy link
Member

I'm open for PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants