Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus in keyboard #14

Closed
cicelcup opened this issue May 13, 2020 · 5 comments
Closed

Focus in keyboard #14

cicelcup opened this issue May 13, 2020 · 5 comments
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@cicelcup
Copy link

When you are using a front layer that contains one TextField, if you are typing something on it and then it pressed the leading or action bottom in the backdrop appbar, the keyboard remains open instead of lost the focus.
(I cannot wrap

I guess this can be solved adding FocusScope.of(context).unfocus() in the places where fling is called.

(This is the first time in my life that I created some bug report), so please forgive me if I did something wrong.

@daadu daadu added the bug Something isn't working label May 14, 2020
@daadu daadu self-assigned this May 14, 2020
@daadu daadu added this to the v1.0 milestone May 14, 2020
@daadu daadu added this to Needs triage in Bug Triage via automation May 14, 2020
@daadu daadu moved this from Needs triage to High priority in Bug Triage May 14, 2020
@daadu
Copy link
Member

daadu commented May 14, 2020

@cicelcup Thank you for reporting the bug. We might take some time to fix it. Meanwhile you can file PR against it if you want. Contributions are welcomed!

@cicelcup
Copy link
Author

I already do the change. But I am not sure well how to do the pull request. I will mention what I have done so far.. First I clone the project, second, I create another branch, third I did the change, four I commit and then I try to push it but the server rejected... Please can you be kind to tell me how to do the pull request?

@daadu
Copy link
Member

daadu commented May 14, 2020

@cicelcup you need to "fork" this repo first to your own profile. then clone that repo to your local machine. push the change to your "forked" repo. then create PR from your repo to this one (fluttercommunity/backdrop)

@cicelcup
Copy link
Author

Thank you for teaching me. I already did what you indicated me.. Regards...

@daadu
Copy link
Member

daadu commented May 15, 2020

@cicelcup Thank you for your contribution at #16. The fix is pushed to pub. Run flutter pub upgrade.

Also you have been added as contributor in README.md.

Hope to see more contributions from you.

@daadu daadu closed this as completed May 15, 2020
Bug Triage automation moved this from High priority to Closed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Bug Triage
  
Closed
Development

No branches or pull requests

2 participants