New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/customizable inkwell #65
Conversation
@WieFel Should we add |
@daadu what do you mean exactly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this. So that the itemCustomBorder
is added to item
itself along with InkWell
, and we can rename itemCustomBorder
to itemShape
Rest looks fine to me. |
There is one problem left: backLayer: BackdropNavigationBackLayer(
items: [
ListTile(title: Text("Widget 1")),
ListTile(title: Text("Widget 2"), tileColor: Colors.orange,),
],
onTap: (int position) => {setState(() => _currentIndex = position)},
separatorBuilder: (context, index) => Divider(),
itemCustomBorder:
RoundedRectangleBorder(borderRadius: BorderRadius.circular(16)),
), The border is not actually applied to the list item: Adding |
User can anyways modify |
I only suggested setting shape of |
18fc37a
to
e4c9704
Compare
@daadu ok no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This feature has landed with |
Makes the
InkWell
inBackdropNavigationBackLayer
customizable:itemPadding
: set padding for list items.itemCustomBorder
: set custom border for items.itemSplashColor
: set custom splash color.Closes #59.