Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the code more manageable #1

Closed
brianegan opened this issue Dec 5, 2017 · 2 comments · Fixed by #99
Closed

Make the code more manageable #1

brianegan opened this issue Dec 5, 2017 · 2 comments · Fixed by #99

Comments

@brianegan
Copy link
Collaborator

Code needs a good refactor / clean up.

@cbenhagen
Copy link
Collaborator

Please add some details about this. I'd like to give this a try.

@brianegan
Copy link
Collaborator Author

brianegan commented Oct 3, 2018

Hey there -- my idea was to replace all StatefulWidgets with a ChewieController, similar to the VideoPlayerController or TextEditingController. The ChewieController would contain a few methods, such as play, enterFullScreen, etc. It would also contain the data to be rendered on all the Widgets, probably as Listenables, such as ChangeNotifier or ValueNotifier.

Rather than passing enterFullScreen methods down the Widget Tree, the ChewieController would be wrapped in an InheritedWidget that all sub-Widgets could access.

@cbenhagen cbenhagen mentioned this issue Jan 16, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants