Updated deprecated attribute accentColor to colorScheme.secondary

[pratik-7span]

Updated:

• Updated deprecated attribute accentColor to colorScheme.secondary
• Duration.zero instead of Duration()

[diegotori]

@Ahmadre another gentle reminder regarding a release (not a merge to master) for this change, since it looks like this is breaking the lint checks. Thanks in advance.

[Ahmadre]

@pratik7span could you please check the lint errors and avoid them in your MR? After that we can release.

[pratik-7span]

Hey @Ahmadre Sorry for that. Can you please check again. I removed lint errors from lib.

[Ahmadre]

@pratik7span sorry for the delay I got a lot of things to do.

We merged a major lint errors PR. Could you please check the changes needed to merge this?

[pratik-7span]

@pratik7span sorry for the delay I got a lot of things to do.

We merged a major lint errors PR. Could you please check the changes needed to merge this?

Hey @Ahmadre You can check it now. Thanks!

[diegotori]

@Ahmadre gentle reminder regarding this PR. Thanks in advance.

[pratik-7span]

Do let me know if I need to change anything?

@Ahmadre gentle reminder regarding this PR. Thanks in advance.

[diegotori]

@pratik7span looks like it failed CI formatting checks. Perhaps you may need to address those so that the checks become green.

[diegotori]

@Ahmadre remember, you don't have to maintain this project alone. There are folks such as myself who are willing to step up and approve pull requests and perform releases. Feel free to reach out to me anytime if you want to make this happen.

[Ahmadre]

@Ahmadre remember, you don't have to maintain this project alone. There are folks such as myself who are willing to step up and approve pull requests and perform releases. Feel free to reach out to me anytime if you want to make this happen.

Actually there're other maintainers here who got the same rights 😅 so it's not me alone ^^

[diegotori]

Fair enough, but are they active though? I can definitely cover the other side of the Atlantic since I'm based out of the US East Coast.

Also, you can never have too many maintainers 😄 .

[Ahmadre]

Fair enough, but are they active though? I can definitely cover the other side of the Atlantic since I'm based out of the US East Coast.

Also, you can never have too many maintainers 😄 .

Sorry I tried to add you as a maintainer, but I don't have the rights for it.

[diegotori]

Fair enough, but are they active though? I can definitely cover the other side of the Atlantic since I'm based out of the US East Coast.
Also, you can never have too many maintainers 😄 .

Sorry I tried to add you as a maintainer, but I don't have the rights for it.

I wonder who does have the right? The original owner of the project @brianegan might be able to do this, assuming he's not busy.

[brianegan]

I do have the rights! In fact, I shouldn't at all -- the community should! Rebar and co have done a fantastic job of taking this project to new heights! Therefore, I propose we move this off of my brianegan github account and into the Flutter Community where it can be properly managed. What do folks think of such a proposal?

…

On Thu, Nov 25, 2021 at 1:17 AM Rebar Ahmad ***@***.***> wrote: Merged #552 <#552> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#552 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA65DHADBZEH2SRHQNTW3TUNV6APANCNFSM5E7ON7YQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[diegotori]

I do have the rights! In fact, I shouldn't at all -- the community should! Rebar and co have done a fantastic job of taking this project to new heights! Therefore, I propose we move this off of my brianegan github account and into the Flutter Community where it can be properly managed. What do folks think of such a proposal?

I second that motion. We just have to figure out how to pull this off. Is it as simple as transferring over control to the Flutter Community GitHub account?

Also, you have to make sure that folks who are pointing to your repo directly in their pubspec aren't screwed due to the move, or at the very least communicate said repo move publicly (Reddit FlutterDev, Discord Flutter channel, etc...).

Other than that, once it's in the hands of Flutter Community, then it'll really be in good hands.

[brianegan]

Yah, I have permission to transfer to the Flutter Community. Also, github handles all redirects when you transfer a repo. Should be all good on that side! I'll chat with the Flutter Community folks to make sure this is cool before I do it up.

…

On Thu, Nov 25, 2021 at 3:26 PM Diego Tori ***@***.***> wrote: I do have the rights! In fact, I shouldn't at all -- the community should! Rebar and co have done a fantastic job of taking this project to new heights! Therefore, I propose we move this off of my brianegan github account and into the Flutter Community where it can be properly managed. What do folks think of such a proposal? … <#m_-1618018329985707354_> On Thu, Nov 25, 2021 at 1:17 AM Rebar Ahmad *@*.***> wrote: Merged #552 <#552> <#552 <#552>> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#552 (comment) <#552 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA65DHADBZEH2SRHQNTW3TUNV6APANCNFSM5E7ON7YQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . I second that motion. We just have to figure out how to pull this off. Is it as simple as transferring over control to the Flutter Community GitHub account? Also, you have to make sure that folks who are pointing to your repo directly in their pubspec aren't screwed due to the move, or at the very least communicate said repo move publicly (Reddit FlutterDev, Discord Flutter channel, etc...). Other than that, once it's in the hands of Flutter Community, then it'll really be in good hands. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#552 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA65DDOQ4UY3ZRH4ZIOCGTUNZBRFANCNFSM5E7ON7YQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[pratik-7span]

@brianegan @Ahmadre Thank you so much for merging. btw great conversation :)

[diegotori]

@brianegan any word on transferring this project to the Flutter Community? Also, in the short term, we could use a new build so that we're no longer overriding provider in our pubspec in order to get our apps building. Thanks in advance.

[brianegan]

Hey all -- I hadn't gotten any word for over a week via email, just created an issue: fluttercommunity/community#87

[diegotori]

@brianegan that's good news. In the meantime, are you able to release a new build to pub.dev to hold us over until the Flutter Community assumes responsibility of the project?

If you need publishers for pub.dev, I'm able to volunteer. Add me on pub.dev at diegotoridoesandroid@gmail.com.

Thanks in advance.

[brianegan]

@diegotori I'd like @Ahmadre make the call for when to publish a new version since I'm not as involved in the day-to-day and I don't quite know if he had something else in mind before publishing?

If you need to rely on this code ASAP, you can always use a git reference in your pubspec.yaml instead of a version number that points to pub.dev.

[diegotori]

@Ahmadre the ball is in your court on a quick release to pub.dev.

[diegotori]

@brianegan while I can use a git reference in my pubspec, I also depend on it through an internal library. Therefore it isn't as trivial or ideal to have the end-user override chewie to point to a git commit, let alone declaring it in the library's pubspec using that method. For example, if an end-user of my library would want to declare this transitive dependency in their app's pubspec, they would have to declare it in the same way and not through a version number, which is very inconvenient.

@Ahmadre a gentle reminder that myself and other developers are patiently waiting for a new chewie release to pub.dev so that we don't have to resort to pubspec hackery on our ends.

[kamleshwebtech]

any update?? Kindly share the solution. Thanks a lot.