Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong cancel callback on Android #37

Closed
wsxyeah opened this issue Jan 26, 2019 · 0 comments
Closed

Wrong cancel callback on Android #37

wsxyeah opened this issue Jan 26, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@wsxyeah
Copy link

wsxyeah commented Jan 26, 2019

Step to reproduce

  1. Start any download task
  2. Call FlutterDownloader.cancel(taskId: taskId) when in downloading to cancel the task
  3. You will receive the callback with status COMPLETE instead of expected status CANCELED

Cause

See this line of code. When work getting canceled, the status is marked as COMPLETED.

https://github.com/fluttercommunity/flutter_downloader/blame/master/android/src/main/java/vn/hunghd/flutterdownloader/DownloadWorker.java#L232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wsxyeah @hnvn