Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service error handling #148

Closed
dkja opened this issue Jan 16, 2021 · 4 comments
Closed

Service error handling #148

dkja opened this issue Jan 16, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@dkja
Copy link

dkja commented Jan 16, 2021

Can I handle service initialization error ? I think that getIt.addReady() should relay error from all services (from Futures) to returned Future

@escamoteur
Copy link
Collaborator

hmm interesting thought, this would requipre to save errors till someone calls allReady

@dkja
Copy link
Author

dkja commented Jan 16, 2021

Future contains error, so I think that return errorful Futures (or only first may be ok too) is enough.

@escamoteur
Copy link
Collaborator

Wow, that was a tough one, but only because I tackled it from the wrong side first. I also found some quirks that hadn't really bothered anyone so far.
Is included in the next release

@escamoteur
Copy link
Collaborator

Implemented in V6.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants