Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep code before imports #9

Closed
nodinosaur opened this issue May 6, 2020 · 5 comments
Closed

Keep code before imports #9

nodinosaur opened this issue May 6, 2020 · 5 comments
Assignees
@gleich
Labels
bug Something isn't working
Milestone
3.0.0

Comments

@nodinosaur
Copy link

I just ran the importer and it broke the project.

Reviewing the file that was reported by the analyzer as broken and comparing to GitHub I saw that library XXXXXX; had been stripped.
@github-actions
Copy link

github-actions bot commented May 6, 2020

👋 Hello! Thanks for submitting a issue 😄! @Matt-Gleich Will try to respond as soon as possible.

@gleich gleich self-assigned this May 6, 2020
@gleich gleich added the question Further information is requested label May 6, 2020
@gleich
Copy link
Member

gleich commented May 6, 2020

👋🏼 Hello! Can you please provide the following information? Thanks!

  1. What version of import_sorter are you using
  2. Would you be able to send the file or is it a private project (easier for me to debug)
  3. Does the library come before the imports?

@nodinosaur
Copy link
Author

👋Sure:

  1. import_sorter: any (my understanding is that this implies latest)
  2. Flutter SDK reference for you: animated_icons.dart
  3. The library keyword does seem to appear above imports, yes.

@gleich
Copy link
Member

gleich commented May 6, 2020

Ah, I thought that might be it. At the moment import_sorter removes all code above the imports. I was under the impression that there was never any code before imports but I guess not! I will look at fixing it today and you should see available in 2.1.0. Let me know if have any other questions!

@gleich gleich changed the title strips library XXXXXX; Keep code before imports May 6, 2020
@gleich gleich added bug Something isn't working and removed question Further information is requested labels May 6, 2020
@gleich gleich added this to the 2.1.0 milestone May 6, 2020
@gleich
Copy link
Member

gleich commented May 9, 2020

This is going to be available tonight in version 3.0.0 when I close all the other issues

@gleich gleich closed this as completed May 9, 2020
@gleich gleich mentioned this issue May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gleich gleich

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@nodinosaur @gleich