Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(all): Fix example links on pub.dev #1863

Merged
merged 1 commit into from May 29, 2023
Merged

docs(all): Fix example links on pub.dev #1863

merged 1 commit into from May 29, 2023

Conversation

vbuberen
Copy link
Collaborator

Description

Due to wrong links under repository tag in pubspec.yaml of every single package we have an issue where on pub.dev clicking on example/lib/main.dart link (here it is at the top of the page), which is generated by pub.dev itself, users were redirected to 404 page.
Found a solution here: dart-lang/pub-dev#3288

Related Issues

Closes #1861

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen added the documentation Improvements or additions to documentation label May 29, 2023
@vbuberen vbuberen merged commit d726035 into main May 29, 2023
73 of 100 checks passed
@vbuberen vbuberen deleted the fix/example_link branch May 29, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Documentation]: share_plus package example main.dart link broken in pub.dev
1 participant