Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request][sensors_plus]: make package in pubspec.yaml the same with group in build.gradle #2091

Closed
zhyky opened this issue Aug 23, 2023 · 2 comments · Fixed by #2109
Closed
Labels
enhancement New feature or request triage

Comments

@zhyky
Copy link

zhyky commented Aug 23, 2023

Plugin

sensors_plus

Use case

Currently, sensors_plus plugin has different value between package in pubspec.yaml and group in build.gradle

in pubspec.yaml

flutter:
  plugin:
    platforms:
      android:
        package: dev.fluttercommunity.plus.sensors
        pluginClass: SensorsPlugin

in android/build.gradle

group 'io.flutter.plugins.sensors'
version '1.0-SNAPSHOT'

This will lead to strange behavior when checking tools written in dart read the package in pubspec.yaml

Proposal

Please make these two value same

@zhyky zhyky added enhancement New feature or request triage labels Aug 23, 2023
@vbuberen
Copy link
Collaborator

Thanks for suggestion.

This will lead to strange behavior when checking tools written in dart read the package in pubspec.yaml

Do you have any examples of such strange behavior?

@zhyky
Copy link
Author

zhyky commented Aug 24, 2023

Thanks for suggestion.

This will lead to strange behavior when checking tools written in dart read the package in pubspec.yaml

Do you have any examples of such strange behavior?

We have implemented a tool to run after flutter build aar to publish Plugin AAR to internal maven repository.

Before publish each AAR, the tool has a checking step to determinate whether it needs to be published.

The checking step use the package in pubspec.yaml, but the real output AAR's package is the group in build.gradle

All other Flutter plugin we are using have same value between package in pubspec.yaml and group in build.gradle, except sensors_plus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants