Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(device_info_plus): Add note about arch returned value on MacOS #2220

Merged
merged 1 commit into from Oct 5, 2023

Conversation

vbuberen
Copy link
Collaborator

@vbuberen vbuberen commented Oct 5, 2023

Description

Added an explanation that for apps running via Rosetta arch parametercan bex86_64to avoid confusion like happened in #2213. Additionally removed a few conditions to check iOS properties as code frommacos` folder won't even run for iOS target.

Related Issues

#2213

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@nohli nohli merged commit 80409e2 into main Oct 5, 2023
19 checks passed
@nohli nohli deleted the refactor/macos_device_info branch October 5, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants