Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android_alarm_manager): Add Kotlin dependency and convert AlarmBroadcastReceiver class to Kotlin #2271

Conversation

TheFinestArtist
Copy link
Contributor

Description

Initial commit for converting Android Alarm Manager from Java to Kotlin.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution. Sorry for getting to this PR only now.
Feel free to continue your conversion to Kotlin for the plugin.

@vbuberen vbuberen force-pushed the fix/android_alarm_mananger_kotlin branch from aa91e8e to 0052d3f Compare November 29, 2023 07:22
@vbuberen vbuberen merged commit 1ecb676 into fluttercommunity:main Nov 29, 2023
10 checks passed
@TheFinestArtist
Copy link
Contributor Author

I will continue the conversion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants