build(alarm_manager_plus)!: Target Java 17 on Android #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelbeltran
approved these changes
Mar 18, 2024
2 tasks
This was referenced Mar 18, 2024
|
Quick note here: this is the only plugin I've seen targeting 17 (usually it's 1.8), and it did break my project. Not sure whether really this is a flutter thing they should fix, but fyi. |
having the same issue. Is there a work-around or do I need to reference an older version of share_plus? |
|
It is not an issue. Update your project the similar way as plugin updated in this PR and everything will work fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Targeting Java 17 to be up to date with ecosystem.
Considering that we are using Gradle 8.4 now no compatibility problems expected: https://docs.gradle.org/current/userguide/compatibility.html
Also, with this change users should not see such deprecation warnings anymore:
Marking as a breaking change to highlight it in release notes.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).