Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBSOCKET #24

Closed
kzawadi opened this issue Mar 6, 2021 · 8 comments
Closed

WEBSOCKET #24

kzawadi opened this issue Mar 6, 2021 · 8 comments

Comments

@kzawadi
Copy link
Member

kzawadi commented Mar 6, 2021

I have this weird problem....when I use HTTP everything goes well the keep alive is pinging and fine But when I use websocket....i connect and everything goes well but after 60 seconds (Defualt janus timeout) the session get terminated..(session timeout)...

if i switch to HTTP everything is fine so i think and i can HTTP sending those keepalive packets....is anything wrong

@shivanshtalwar0
Copy link
Collaborator

Yes i am aware of this issue i would advise you to try v2 branch which is stable and features brand new api
Soon i am going to deprecate previous version

@shivanshtalwar0
Copy link
Collaborator

For example of how v2 api works kindly check
Videoroom_v2

@kzawadi
Copy link
Member Author

kzawadi commented Mar 6, 2021

okay i see ..nice work my man .... though no pub update as of now I have tried getting this update through git but

Because every version of flutter_test from sdk depends on stream_channel 2.1.0-nullsafety.1 and every version of janus_client from git depends on stream_channel ^2.1.0, flutter_test from sdk is incompatible with janus_client from git.

@kzawadi kzawadi closed this as completed Mar 6, 2021
@shivanshtalwar0
Copy link
Collaborator

okay i see ..nice work my man .... though no pub update as of now I have tried getting this update through git but

Because every version of flutter_test from sdk depends on stream_channel 2.1.0-nullsafety.1 and every version of janus_client from git depends on stream_channel ^2.1.0, flutter_test from sdk is incompatible with janus_client from git.

this issue is fixed now in this commit
also it now fully supports videoroom using v2 api, i would highly recommend playing with it.
let me know your experience with it! :)

@kzawadi
Copy link
Member Author

kzawadi commented Mar 7, 2021

nice one... I like the new janusSession and plugin API it gives more granular controls .....the previous one you have to kinder nest functions a lot...but also the previous one(plugin class) had this "onRemoteStream" which is now I think deprecated and instead I think to get a remote stream you have to "plugin.webRTCHandle.peerConnection.onAddStream" .....in audio bridge its quite confusing as is it the same thing coming out as previous version (onRemoteStream) or what ...i need clarifications as Janus audio bridge already mixes all peer audio (MCU) so onaddstream will the stream be added when another peer join or is it just the first time it connects......(English second language)

@shivanshtalwar0
Copy link
Collaborator

Yes everything related to old code would be deprecated soon only example updated as of now is videoroom_v2 rest code is as it is which is still using old api version as i will develop v2 you will see old code go away piece by piece

@shivanshtalwar0
Copy link
Collaborator

For audio bridge example i will soon write example using new api once i am done with unified support in v2

@kzawadi
Copy link
Member Author

kzawadi commented Mar 7, 2021

@shivanshtalwar0 nice work man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants