Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test uncovered code #88

Closed
2 tasks done
Avaq opened this issue Apr 19, 2017 · 0 comments
Closed
2 tasks done

Unit test uncovered code #88

Avaq opened this issue Apr 19, 2017 · 0 comments
Assignees
@Avaq
Milestone
6.0.0

Comments

@Avaq
Copy link
Member

Avaq commented Apr 19, 2017 •
edited

The new ES6 code is not completely covered by the old unit tests. In attaining 100% coverage, we should be sure to test for the following:

  • the behavior of never, especially with regards to race
  • the optimized implementations of transformations which live on Rejected, Resolved and Never.
@Avaq Avaq created this issue from a note in ES6 Rework (To Do) Apr 19, 2017
@Avaq Avaq added this to the 6.0.0 milestone Apr 19, 2017
@Avaq Avaq moved this from To Do to In progress in ES6 Rework May 6, 2017
Avaq added a commit that referenced this issue May 6, 2017
@Avaq
Change the way tests are executed
2d9aa8e 
We no longer compile our unit-testing code. Instead, we bundle
the tests with Rollup, instrumenting them for coverage in the
process. We then run the tests natively on Node v7. We trust
that Buble will do its job and transpile the code such that if
the tests pass on the native code, they do on the transpiled.

This was the only approach in which I was able to get both:

* Stack traces reporting the correct origin of thrown errors
* Test coverage reports highlighting the correct ES6 code

Now that code coverage reports are finally intelligable, I can
move on to work on #88.
Avaq added a commit that referenced this issue May 6, 2017
@Avaq
Improve type-checking at fluent calls
ebaf11a 
Also adds type-checking to the output of user supplied functions
and resolution of user-uspplied Futures, where appropriate.

Contributes to the resolution of #88 and #90.
@Avaq Avaq removed this from In progress in ES6 Rework May 6, 2017
@Avaq Avaq self-assigned this May 6, 2017
@Avaq Avaq mentioned this issue May 7, 2017
Merged
@Avaq Avaq closed this as completed May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Avaq Avaq

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@Avaq