-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUC support #67
Comments
Thanks for the pointer, I will have a look. |
The main advantage of extensions is that they are extensible by the developer. You can use the lib and use your custom namespace extension. We could have a getter for extensions, a bit similar to your nil test, that could look like (peudo-code): var muc MUC
if ok := p.Get(&MUC); ok {
// Handle MUC
} Anyway, I am still torn between simplicity of your approach and trying to build something that is a bit more complex but could handle more developers' needs ... |
Sounds nice - i really do not like this code: code snipped from thrempp |
Ok thanks for feedback, I will try to prepare something as discussed during the week-end :) |
Here is what the code looks like for Message extension: 4a4c485 I will now expand Presence to have []PresExtension and implement a similar Get method. |
I now think that oob and MUC presence extension should be ok for your needs. |
#69 is for MUC not HTML |
Oups, sorry, it is #70 |
Supi - now i need time to migrate by Programms ;) Thank you for developing and maintaining xmpp library, it is really useful |
Thanks for your feedback and your help :) And no rush / no pressure to upgrade your programs, I have plenty to do as well. |
I found my old code again ... yaja- most of the handling is a little bit trash.
But the library of structs is still not bad (here: xmpp)
The parsing is really easy: https://dev.sum7.eu/genofire/yaja/blob/master/client/comm.go#L9-37.
Another nice feature is, that it is not necessary to iterate over all
Message.Extensions
we could just make aif PresenceClient.MUC !=nil
becauseomitempty
pointer are filled withnil
if the values for thisstructs
are not given.atm i miss somethings to replace other libraries in related project:
The text was updated successfully, but these errors were encountered: