t: add active column, move sample payloads
#432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem(s): Some sharness tests in flux-accounting's testsuite don't contain the "active" column in the payloads that get sent to the priority plugin. These sample payloads are starting to grow very large because they have a lot of fields per-user, and they clog up the test files. Add the "active" column to the key-value pairs of the test payloads that get sent to the priority plugin in the sharness tests. Move these key-value pairs to separate JSON files that get loaded into their respective test files instead of creating them within the test directly.
cmoussa1
added
improvement
cmoussa1
changed the title
active column, move sample payloadsactive column, move sample payloads
|
Thanks for approving @jameshcorbett! Setting MWP here |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 23 23
Lines 1457 1457
=======================================
Hits 1215 1215
Misses 242 242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem(s)
Some sharness tests in flux-accounting's testsuite don't contain the
activecolumn in the payloads that get sent to the priority plugin.These sample payloads are starting to grow very large because they have a lot of fields per-user, and they clog up the test files.
This PR adds the
activecolumn to the key-value pairs of the test payloads that get sent to the priority plugin in the sharness tests.It also moves these key-value pairs to separate JSON files that get loaded into their respective test files instead of creating them within the test directly.