travis-ci: fix docker deploy #1684
Conversation
Problem: Docker image auto-deployment for new merges to master or tags was broken due to a testing "repo slug" left in the test to ensure we were running in the official flux-core repository. Update the repo slug to `flux-framework/flux-core`. Also, include the DOCKER_TAG=t variable for CentOS 7 builds so we get a centos docker image. Finally, update the names of builders in Travis-CI for clarity.
Remove the `set -x` left over from testing in docker-run-checks.sh.
|
This should fix the Docker auto-deploy for merges to flux-core@master, however, it is difficult to know for certain until we actually try it. Sorry! |
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
- Coverage 79.29% 79.28% -0.01%
==========================================
Files 186 186
Lines 35059 35059
==========================================
- Hits 27801 27798 -3
- Misses 7258 7261 +3
|
|
Don't merge this quite yet, I have a couple other improvements I want to make to the travis build scripts. |
Add src/lib/travis-lib.sh with functions for folding and timing script output in Travis-CI logs, and use this library in docker-run-checks.sh and travis_run.sh. By default, folded lines also get timing information.
Move variable setup to before_install section of travis, so that the output gets collapsed in travis logs for a cleaner look.
|
In addition to hopefully fixing the deploy, I added some support for "folding" some of the output from |
|
Ooops.. noticed one other thing. aspell is missing from the images so we're not getting the docs spellchecked. Let me fix that in this PR as well... Sorry for all the blunders! |
Problem: spellcheck tests were skipped in Travis because aspell was not installed in the base images. Add aspell and aspell-en to CentOS and Ubuntu Dockerfiles.
Problem: t2201-job-cmd.t sets a HAVE_FLUX_SECURITY prereq by checking for the `sign-type` arg on the flux-job command. However, this arg exists on `flux job submitbench` not just flux-job, so the test was failing. Adjust the test to use `flux job submitbench` so the security tests are not skipped.
|
Ok, this one is ready for merge I think. Then we can see if the deploy is still broken. |
|
ugh almost all the builds on master failed. This is a new one: Also some of the builds have truncated output and then move on as if they've failed. I tried re-pushing the old master (to my own fork), and it fails in the same way, so I guess these failures were not introduced with this PR, and perhaps Travis is hosed... |
|
This does seem to be an output handling issue. I tested a push where all output from make/make check was suppressed and all builds passed. Might have to open a travis-ci issue on this one. 🤷♂️ |
This PR fixes some errors in the original travis docker PR (#1670):