libflux/msg_handler: improve lookup of message handlers for RPCs #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of maintaining an array indexed by matchtag to quickly locate message handlers for RPCs, use a zhashx configured to use matchtags as hash keys. This should scale just as well with less complexity.
Problem: flux_msg_handler_delvec() calls functions like free() which might overwrite errno. Save and restore errno inside the function, and then remove save/restore in flux_msg_handler_addvec() error path.
Save/restore errno in internal free_msg_handler(), then eliminate awkward errno preserving code in flux_msg_handler_create() error paths.
Problem: flux_msg_handler_destroy() calls functions that might overwrite errno. Save/restore errno.
Problem: flux_msg_handler_create() segfaults on a NULL flux_t handle. Add an EINVAL check.
Problem: flux_dispatch_requeue() segfaults on a NULL argument. Return EINVAL flux_t argument is NULL
Codecov Report
@@ Coverage Diff @@
## master #1807 +/- ##
==========================================
+ Coverage 79.65% 79.68% +0.02%
==========================================
Files 187 187
Lines 34599 34575 -24
==========================================
- Hits 27561 27552 -9
+ Misses 7038 7023 -15
|
|
Nice improvement! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1804, this PR simplifies the mechanism used to look up message handlers (by integer matchtag) for received request messages. The current mechanism is hand-coded table lookup. The replacement is
zhashx_t, a well tested container.There is some additional cleanup of errno handling and handling of invalid arguments.
A trivial test was added to ensure invalid arguments cause functions to fail with EINVAL.
Also I tossed in @grondo's build system fix to AM_TESTS_ENVIRONMENT usage suggested in #1803.