job-manager: fix uninitialized variable warning in jobtap.c #3481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: In job-manager/jobtap.c:jobtap_get_priority() a NULL va_list and fmt is passed to the function jobtap_args_vcreate(). Though the va_list argument is only used if fmt != NULL, some compilers complain that `va_list ap` may be used uninitialized in this function. Instead of being lazy, split the function that creates the plugin arguments into two -- one that takes va_list argument and one that does not. This is cleaner code anyway.
Codecov Report
@@ Coverage Diff @@
## master #3481 +/- ##
==========================================
- Coverage 82.43% 82.43% -0.01%
==========================================
Files 319 319
Lines 48369 48374 +5
==========================================
+ Hits 39874 39875 +1
- Misses 8495 8499 +4
|
|
Thanks! We'll be carrying this one as a patch in the v0.23 RPMS 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers complain about
va_list apbeing used uninitialized injobtap_get_priority().Split the plugin args creation function into two parts, one that take a
va_listand one that doesn't so that an uninitializedva_listdoesn't need to be used when the calling function doesn't take variable arguments.