python: fix return from flux.importer.import_plugins() when no plugins found #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When flux.importer.import_plugins() does not find any plugins to import, it returns an empty list, but the function should always return a dict. Return an empty dict when no plugins are found in import_plugins().
Problem: There is no test that ensures the flux.importer.import_plugins function, used by the job validator, returns a dict and not a list when there are no plugins found. Because there is no import_plugins() unit test, simply add a specific test to t2110-job-ingest-validator.t which verifies this case.
|
Felt bad that there was no test here, so I added a simple one to the job-validator sharness tests. |
Codecov Report
@@ Coverage Diff @@
## master #4288 +/- ##
=======================================
Coverage 83.56% 83.56%
=======================================
Files 388 388
Lines 64848 64848
=======================================
+ Hits 54189 54193 +4
+ Misses 10659 10655 -4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When flux.importer.import_plugins() does not find any
plugins to import, it returns an empty list, but the function should
always return a dict.
Return an empty dict when no plugins are found in import_plugins().
As discovered by @wkharold in #4285