job-archive: improve logging on parse job error #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The error job-archive.err[0]: job_info_lookup_continuation: parse job was recently observed, which did not provide insight into the deeper problem. Solution: Improve the error message by using json_unpack_ex() to get parsing error information. Also add the job ID to the error output. Fixes flux-framework#4403
Codecov Report
@@ Coverage Diff @@
## master #4422 +/- ##
==========================================
- Coverage 83.32% 83.32% -0.01%
==========================================
Files 395 395
Lines 66644 66648 +4
==========================================
+ Hits 55529 55532 +3
- Misses 11115 11116 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The error
job-archive.err[0]: job_info_lookup_continuation: parse job
was recently observed, which did not provide insight into the deeper
problem.
Solution: Improve the error message by using json_unpack_ex() to
get parsing error information. Also add the job ID to the error
output.
Fixes #4403