ingest: require job queue if [queues] are configured #4616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: if queues are configured, but no default queue is configured, and a job is submitted without a queue, the job is ingested and allowed to fail later Modify the 'defaults' frobnicator plugin to reject such a job at ingest. Fix sharness limit tests that were using queue configurations that are now considered invalid. Fixes flux-framework#4614
Problem: there is no test coverage for the frobnicator defaults plugin rejecing a job with no queue when queues are configured, but no default queue is configured. Add a test.
garlick
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4616 +/- ##
==========================================
- Coverage 83.40% 83.40% -0.01%
==========================================
Files 411 411
Lines 68803 68805 +2
==========================================
+ Hits 57388 57389 +1
- Misses 11415 11416 +1
|
|
Thanks! Setting MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: if queues are configured, but no default queue is configured, and a job is submitted without a queue, the job is ingested and allowed to fail later.
Modify the 'defaults' frobnicator plugin to reject such a job at ingest.