Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: fix failure on a system with fully-qualified hostname #4825

Merged
merged 1 commit into from Dec 11, 2022

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Dec 11, 2022

Problem: In t2616-job-shell-taskmap.t an expected hostname is compared to hostname -s which breaks the test on systems with a fully-qualified hostname.

Drop the -s argument to hostname to make the test more reliable.

Problem: In t2616-job-shell-taskmap.t an expected hostname is
compared to `hostname -s` which breaks the test on systems with a
fully-qualified hostname.

Drop the `-s` argument to hostname to make the test more reliable.
@grondo
Copy link
Contributor Author

grondo commented Dec 11, 2022

This issue was detected when trying to build RPMs in the TOSS buildfarm.

@grondo grondo changed the title fix testsuite failure on a system with fully-qualified hostname testsuite: fix failure on a system with fully-qualified hostname Dec 11, 2022
Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit dba584e into flux-framework:master Dec 11, 2022
@grondo grondo deleted the taskmap-test-fix branch December 11, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants