job-manager: fix for job priority not reset after a duplicate urgency update #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The job manager prioritization code contains an optimization that avoids posting a priority event if the priority did not change after reprioritization. However, this causes jobs that are in PRIORITY state to get stuck there, since they normally transition to SCHED as a result of the priority event. This occurs if a job's urgency is updated to the same value, e.g. if a held job is held again. Force a priority event to be emitted in states other than SCHED, even if the priority is unchanged. This allows jobs kicked back to PRIORITY state to transition to SCHED, even if a duplicate urgency value is set. Fixes flux-framework#4940
grondo
changed the title
chu11
reviewed
Feb 15, 2023
t/t2214-job-manager-hold-limited.t
Outdated
Comment on lines
37
to
43
| test_expect_success 'job-manager: hold job 3, 5 again (issue #4940)' ' | ||
| flux job urgency $(cat job3.id) 16 && | ||
| flux job urgency $(cat job3.id) 16 && | ||
| flux job urgency $(cat job3.id) 16 && | ||
| flux job urgency $(cat job3.id) 16 && | ||
| flux job urgency $(cat job5.id) 16 | ||
| ' |
There was a problem hiding this comment.
should be urgency 0/hold instead of 16?
There was a problem hiding this comment.
Thanks. Fixed that blunder and force pushed the result.
Problem: None of the job manager job "hold" tests have a reproducer for holding an already held job as described in issue flux-framework#4940. Sprinkle some `flux job urgency id 0` in the tests on already held jobs to act as a reproducer for flux-framework#4940.
|
Thanks! I've set MWP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #4940, and adds some tests to the
holdsuite of sharness tests to set urgency to hold already held jobs to ensure we don't see this particular issue again.