testsuite: fix setup error in system tests #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
changed the title
|
re-pushed, noticed a typo in the commit message :-) |
grondo
approved these changes
Apr 17, 2023
Problem: In t9000-system.t the FLUX_TEST_INSTALLED_PATH variable is setup if 'debug' is set. However, the check for 'debug' is done before sharness is sourced, so the `-d` option when running the tests doesn't matter. This lead to the t9000-system.t tests failing when running make check in a docker container. Solution: Instead of checking for 'debug' to set FLUX_TEST_INSTALLED_PATH, check for FLUX_ENABLE_SYSTEM_TESTS.
|
@grondo thanks, fixed up that typo in the commit message, rebased, and re-pushed. I'll set MWP. |
Codecov Report
@@ Coverage Diff @@
## master #5102 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 444 444
Lines 76623 76623
=======================================
Hits 63715 63715
Misses 12908 12908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In t9000-system.t the FLUX_TEST_INSTALLED_PATH variable is setup if 'debug' is set. However, the check for 'debug' is done before sharness is sourced, so the
-doption when running the tests doesn't matter. This lead to the t9000-system.t tests failing when running make check in a docker container.Solution: Instead of checking for 'debug' to set FLUX_TEST_INSTALLED_PATH, check for FLUX_ENABLE_SYSTEM_TESTS instead.