ensure license and other informational files appear in distribution tarball #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garlick
approved these changes
Apr 24, 2023
|
Thanks! |
Problem: The flux-core LICENSE file is not included in the distribution tarball created by `make dist`. Add LICENSE to the top Makefile.am EXTRA_DIST.
Problem: The license files under src/common/libccan are not included in the distribution tarball created by `make dist`. Add the missing files to EXTRA_DIST so they appear in the distribution tarball.
Problem: The tomlc99 LICENSE and README files are missing from the distribution tarball created by `make dist`. Add these files to EXTRA_DIST so the appear in the distribution tarball.
Codecov Report
@@ Coverage Diff @@
## master #5113 +/- ##
===========================================
+ Coverage 55.21% 83.13% +27.91%
===========================================
Files 413 453 +40
Lines 71022 77655 +6633
===========================================
+ Hits 39213 64556 +25343
+ Misses 31809 13099 -18710 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jan-janssen noticed that the flux-core
LICENSEfile was missing from our distribution tarball.This PR adds that and some other missing licenses and informational files to
EXTRA_DISTwhere appropriate so those files are included in the distribution.