ci: add fedora38 builder, update flux-security default to 0.8.0 #5160
Conversation
src/test/docker/fedora38/Dockerfile
Outdated
| # Python | ||
| python36 \ |
There was a problem hiding this comment.
dumb question, if python 3.11 is the default python, why install 3.6? I notice its there for some other fedora images. Or perhaps there's some packaging subtlety with fedora I'm completely missing.
There was a problem hiding this comment.
Good catch, I just copied the Fedora dockerfile (probably did that before too 🤦). Definitely should remove that before merging this!
There was a problem hiding this comment.
Fixed that, updated the fluxrm/testenv:fedora38 image, and force-pushed here.
|
I also noticed that the default flux-security version should have been updated to v0.8.0, so I've done that here. I'll update the PR title to include that change, but didn't really see the need the split into a whole other PR at this time. Please let me know if you'd rather that change be split off from this PR. |
grondo
changed the title
I think it's ok. |
Problem: flux-core can't run ci tests on fedora38 since there's no base Dockerfile for this Fedora version. Add a Dockerfile for fedora38.
Problem: There is no CI build that tests with Python 3.11 or GCC 13. Add a Fedora 38 build to ci which has these versions of Python and GCC.
Problem: The default FLUX_SECURITY_VERSION used in docker-run-checks.sh is v0.7.0, but there is v0.8.0 version of flux-security that should be used in testing. Update the default FLUX_SECURITY_VERSION to 0.8.0.
Codecov Report
@@ Coverage Diff @@
## master #5160 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 453 453
Lines 77787 77787
=======================================
+ Hits 64665 64672 +7
+ Misses 13122 13115 -7 |
This PR adds a builder for Fedora 38, since this distro has GCC 13 and Python 3.11, a combo we're not yet testing.
The caliper version we've pinned won't build in fedora38, and the newest version isn't compatible with the current code that calls it in flux-core, so I've just disabled Caliper here. Honestly, I'm wondering if we should just remove the caliper support? Eh, not too much of a headache yet, so we can save that decision for another day.