Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add usage note for --add-file submission cli option #5239

Merged
merged 1 commit into from Jun 8, 2023

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Jun 8, 2023

Problem: It may be tempting for users to use the --add-file=PATH job submission cli option to broadcast large files to their job, a use which would be inappropriate.

Add a note to this option explaining when --add-file should be used vs the shell stage-in plugin.

Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Problem: It may be tempting for users to use the --add-file=PATH
job submission cli option to broadcast large files to their job,
a use which would be inappropriate.

Add a note to this option explaining when --add-file should be used
vs the shell stage-in plugin.
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #5239 (1eaab83) into master (65eb9f0) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5239      +/-   ##
==========================================
- Coverage   83.76%   83.75%   -0.02%     
==========================================
  Files         448      448              
  Lines       75956    75956              
==========================================
- Hits        63628    63619       -9     
- Misses      12328    12337       +9     

see 9 files with indirect coverage changes

@mergify mergify bot merged commit 1bbbab0 into flux-framework:master Jun 8, 2023
32 checks passed
@grondo grondo deleted the add-file-clarify branch September 7, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants