Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: add broker.dmesg_restrict configuration key #5278

Open
garlick opened this issue Jun 18, 2023 · 4 comments
Open

broker: add broker.dmesg_restrict configuration key #5278

garlick opened this issue Jun 18, 2023 · 4 comments

Comments

@garlick
Copy link
Member

garlick commented Jun 18, 2023

Problem: flux dmesg involves a lot of sudoing when diagnosing a system instance.

A number of services were restricted to instance owner out of an abundance of caution. Possibly this one could be opened to guests for convenience?

If necessary, we could restrict access to "local only" to give rank 0 a modicum of protection for sites that run it on a node with restricted access.

Just a thought I wanted to open for discussion.

@grondo
Copy link
Contributor

grondo commented Jun 18, 2023

As a data point, the kernel dmesg logs are also restricted to root. Most things I would worry about are probably logged to rank 0 only for now, but perhaps not in the future if the execution system is redone.

@garlick
Copy link
Member Author

garlick commented Jun 18, 2023

It's a good point that the content is pretty open ended and developers should probably not have to worry about what they might be exposing when deciding whether or not to log stuff. They should be focused on what's useful.

If we really thought this was an issue (say on a development system) we could add configuration support for enabling guest access, similar to the kernel sysctl kernel.dmesg_restrict but it's probably not worth it. You've convinced me. I'll close this. Thanks!

@garlick garlick closed this as completed Jun 18, 2023
@grondo
Copy link
Contributor

grondo commented Jun 18, 2023

That's what I was thinking, a configuration setting that admins could set on the mgmt nodes would be pretty useful probably.

@garlick
Copy link
Member Author

garlick commented Jun 18, 2023

Oh well it'd be easy to add. I'll reopen this and retitle.

@garlick garlick reopened this Jun 18, 2023
@garlick garlick changed the title broker: consider allowing guest access to dmesg logs broker: add broker.dmesg_restrict configuration key Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants