modules/content: drop incorrect assertion #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: sometimes brokers hit an assertion when the content module is unloaded during shutdown. The assertion is that there are no pending load/store operations waiting on a cache entry when it is destroyed. This is certainly possible, depending on the behavior of users of the load/store RPCs. In the case of unload in rc3, dependent modules would have already been unloaded, so it seems safe to simply destroy any pending RPCs without responding to them. Destroy them, if present. Fixes flux-framework#5706
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5781 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 509 509
Lines 82486 82486
=======================================
Hits 68737 68737
Misses 13749 13749
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: sometimes brokers hit an assertion when the content module is unloaded during shutdown.
The assertion is that there are no pending load/store operations waiting on a cache entry when it is destroyed. This is certainly possible, depending on the behavior of users of the load/store RPCs. In the case of unload in rc3, dependent modules would have already been unloaded, so it seems safe to simply destroy any pending RPCs without responding to them.
Destroy them, if present.
Fixes #5706