github: run asan build on fedora36 #5800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The address sanitizer CI build started failing for unknown reason. The failure is occurring in the make program before even running any tests in 'make check.' Take the following steps to attempt to address the issue: - The asan build currently runs on Fedora 34, which is getting old at this point. Update the sanitizer run to use Fedora 36. - Drop the LD_PRELOAD of the libasan library, which seems to be causing the failure in some unrelated programs not compiled with -fsanitize=address (a guess). - Add 'verify_asan_link_order=false' to ASAN_OPTIONS to avoid libasan complaints about link order. This is only important if malloc, free, etc., are replaced by libs. In that case libasan _must_ be first in the link order. See https://github.com/google/sanitizers/wiki/AddressSanitizerFlags - Update -j2 to -j4 (github runners now have 4 vcpus)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5800 +/- ##
==========================================
+ Coverage 83.31% 83.36% +0.05%
==========================================
Files 502 509 +7
Lines 80967 82479 +1512
==========================================
+ Hits 67454 68760 +1306
- Misses 13513 13719 +206 |
|
Thanks! I was still seeing failures with this commit in another branch, not couldn't reproduce it here, so I've set MWP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The address sanitizer CI build started failing for unknown reason. The failure is occurring in the make program before even running any tests in 'make check.'
Take the following steps to attempt to address the issue:
The asan build currently runs on Fedora 34, which is getting old at this point. Update the sanitizer run to use Fedora 36.
Drop the LD_PRELOAD of the libasan library, which seems to be causing the failure in some unrelated programs not compiled with -fsanitize=address (a guess).
Add 'verify_asan_link_order=false' to ASAN_OPTIONS to avoid libasan complaints about link order. This is only important if malloc, free, etc., are replaced by libs. In that case libasan must be first in the link order. See https://github.com/google/sanitizers/wiki/AddressSanitizerFlags
Update -j2 to -j4 (github runners now have 4 vcpus)