Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: set kernel.randomize_va_space=0 for asan build #5802

Merged
merged 1 commit into from Mar 18, 2024

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Mar 18, 2024

Problem: Recent kernel address space layout randomization (ASLR) appears to confuse some versions of address sanitizers, leading to random failures in github CI.

Disable kernel.randomize_va_space for the github asan build to avoid these failures. Thanks to @vchuravy for pointing out the issue.

Since LD_PRELOAD of libasan wasn't the root cause, reinstate preloading the libasan library to get as full coverage as possible.

Fixes #5801.

Problem: Recent kernel address space layout randomization (ASLR)
appears to confuse some versions of address sanitizers, leading to
random failures in github CI.

Disable kernel.randomize_va_space for the github asan build to avoid
these failures. Thanks to @vchuravy for pointing out the issue.

Since LD_PRELOAD of libasan wasn't the root cause, reinstate preloading
the libasan library to get as full coverage as possible.

Fixes flux-framework#5801.
Copy link
Member

@garlick garlick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @grondo and @vchuravy!

@grondo
Copy link
Contributor Author

grondo commented Mar 18, 2024

Thanks! I've set MWP.

@mergify mergify bot merged commit 793add7 into flux-framework:master Mar 18, 2024
33 checks passed
@grondo grondo deleted the asan-again branch March 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: asan build randomly failing
2 participants