python: update required versions of black and mypy #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Github dependabot notified this project of a security issue with black 22.8.0 and recommends updating to 24.3.0. Update black requirement to 24.3.0 and commit all formatting changes as a result. Also make the following other required changes to get this version of black to work: Ensure the python linting action runs on ubuntu-latest in github, otherwise this version of black is not found by pip. Update pyproject.toml to remove tool.black.profile, which the newer black doesn't understand or support. Update pyproject.toml to remove tool.black.exclude, which wasn't being used under pre-commit anyway. Replace with force-exclude, which applies the exclusion pattern even if the targets are passed as a list of files as is done with pre-commit.
Problem: The version of mypy pinned in scripts/requirements-dev.txt is too old for the github ubuntu-latest runner. Update to the latest mypy version 1.9.0.
garlick
approved these changes
Mar 20, 2024
|
Thanks, I've set MWP. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5808 +/- ##
===========================================
+ Coverage 54.85% 83.34% +28.49%
===========================================
Files 461 509 +48
Lines 74783 82485 +7702
===========================================
+ Hits 41020 68749 +27729
+ Misses 33763 13736 -20027
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot noted a potential security issue in our currently required version of
blackin #5806, but a bit more than just bumping the version was required to get the suggestedblackversion working, so I've done that here. This included apply the very minor formatting changes enacted by the new version.The changes also required an update of
mypy, so I've bumped that to the latest version as well. There did not seem to be any fallout.Pending PRs may have to reformatted if they include python code. However, I was surprised how little changed in the formatting when updating to the new black version.