flux-job: fix wait-event -m, --match-context
#5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The `flux job wait-event --match-context` option returns a match when the context value matches but they does not. Fix the logic in wait_event_test_context(). Fixes flux-framework#5845
Problem: Many tests in t2231-job-info-eventlog-watch.t submit and cancel a new job when using the same job would work fine. This makes the test much slower than necessary. Reuse the canceled job where possible. Rename the variable to JOBID to avoid collision with other uses of lowercase `jobid`.
chu11
approved these changes
Apr 1, 2024
t/t2231-job-info-eventlog-watch.t
Outdated
Comment on lines
185
to
188
| # Note: in test below, foo=0 would match severity=0 in buggy version | ||
| test_expect_success 'flux job wait-event w/ bad match-context fails (bad key, good value)' ' | ||
| test_must_fail fj_wait_event --match-context=foo=0 $JOBID exception | ||
| ' |
Problem: No test in t2231-job-info-eventlog-watch.t ensures that the flux-job wait-event -m, --match-context=KEY=VAL doesn't produce a match when the VALUE matches but KEY does not. Add a test.
|
Thanks! I've added the issue reference to the test as suggested and set MWP. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5846 +/- ##
==========================================
+ Coverage 83.26% 83.29% +0.02%
==========================================
Files 511 511
Lines 82694 82690 -4
==========================================
+ Hits 68858 68875 +17
+ Misses 13836 13815 -21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes context matching in
flux job wait-event -m, --match-context, which currently returns a match if the value matches but key does not.