policies: add firstnodex to the known policies #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: the firstnodex policy was added and tested, but couldn't be selected by users because it wouldn't be seen as a known policy. solution: accept the firstnodex value as a known policy in `known_match_policy`
milroy
approved these changes
Apr 6, 2024
trws
added
the
merge-when-passing
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1161 +/- ##
======================================
Coverage 73.9% 73.9%
======================================
Files 103 103
Lines 14395 14395
======================================
Hits 10643 10643
Misses 3752 3752
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: the firstnodex policy was added and tested, but couldn't be selected by users because it wouldn't be seen as a known policy.
solution: accept the firstnodex value as a known policy in
known_match_policy