track KVS API changes in flux-core #271
Conversation
All of the KVS functions and typedefs in flux-core are now namespaced with a flux_ prefix. Several functions were also renamed, such as kvs_commit() -> flux_kvs_commit_anon() Finally, the kvsdir_put_<type> functions were replaced with flux_kvsdir_pack().
|
It sounds like the simulator cleanup should perhaps be a separate pull request? |
|
Good idea, that way @SteVwonder can take his time with the cleanup review. There will be deprecated function warnings until then, but not a big deal. |
garlick
force-pushed
the
kvs_api_names
branch
from
c181e29
to
c02181c
Compare
|
Like the plan. @SteVwonder will be busy throughout this week for IPDPS. |
garlick
changed the title
|
flux-framework/flux-core#1233 is now merged. |
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 72.17% 72.17%
=======================================
Files 29 29
Lines 5862 5862
=======================================
Hits 4231 4231
Misses 1631 1631
Continue to review full report at Codecov.
|
|
OK, the flux-core PR was merged and I restarted travis-ci here and tests passed. I think this is ready to merge. Once that's done, I'll rebase #272 |
This PR tracks flux-core API changes proposed in flux-framework/flux-core#1233. It should not be merged until after that one (and sched travis-ci can be shown to run successfully)
The first commit simply renames functions and types to get sched to comple.
The rest of the commits migrate sched off of functions that now cause "deprecated" warnings from the compiler. In the process, I did some minor refactoring and error handling cleanup in the simulator code surrounding KVS access to job data. I hope it's not a pain to review @SteVwonder!