Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resource-query] Incorporate @morrone's suggestions #322

Closed
dongahn opened this issue Apr 26, 2018 · 0 comments
Closed

[resource-query] Incorporate @morrone's suggestions #322

dongahn opened this issue Apr 26, 2018 · 0 comments

Comments

@dongahn
Copy link
Member

dongahn commented Apr 26, 2018

There are a few nice suggestions made as part of #283, which I've never gotten around to address.

Create this ticket to track them:

  1. scoring API class: Since this class takes several pages of screen space, only declare the functions in the class definition, and use external method definitions.

  2. Use C++ type aliases instead of typedef

  3. Move some of the classes that don't have to be a header file only solution to their own source files for better readability (e.g., class color_t).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant