Fix t2002-qmanager-reload.t with new core resource module #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
=======================================
Coverage 75.45% 75.45%
=======================================
Files 78 78
Lines 7860 7860
=======================================
Hits 5931 5931
Misses 1929 1929 Continue to review full report at Codecov.
|
Problem: The t1002-qmanager-reload.t test will hang during rc3 when used against a Flux where sched-simple acquires resourcess from the resource module. This occurs because the test reloads hwloc XML out of band, and the core resource module (from which sched-simple gets its resource list) has a different resource configuration. This causes sched-simple to reject all free requests as invalid at the end of the test, causing the wait for queue drain to block forever. In order to fix this, the resource module must be reloaded, which in turn requires that sched-simple be reloaded, after hwloc XML is overwritten.
grondo
force-pushed
the
t-qmanager-reload-fixup
branch
from
399bf6e
to
41e955d
Compare
|
Rebased on current master |
|
Thanks! Setting MWP. |
grondo
added
the
merge-when-passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a hang that will come up once flux-framework/flux-core#2949 is merged. Since the
resourcemodule now shares resource configuration with sched-simple via the acquire interface, this module must be reloaded once hwloc data is manually overridden, or else sched-simple will reject free requests after it is reloaded at the end of the test.I suppose since #657 has not been merged yet, I can tack this onto that PR if that would be better.