testsuite: fix a couple brittle tests #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The fluxtion resource and qmanager modules are reloaded multiple times in the t1011-dynstate-change.t test, but sometimes the resource module fails on a hello response for a job with: sched-fluxion-resource.err[0]: parse_R: no scheduling key in R Force the resource module to emit rv1 instead of rv1_nosched for these tests to avoid this error. Fixes flux-framework#907
Problem: The t1006-qmanager-multiqueue.t test fails on systems with older hwloc with an error message like: grow: reader: Error getting the size of block storage device; Add `load-allowlist=node,core,gpu` to the load options for sched-fluxion-resource in this test as instructed by @dongahn. Fixes flux-framework#908 Co-authored-by: Dong H. Ahn <ahn1@llnl.gov>
grondo
force-pushed
the
testsuite-fixes
branch
from
59ee750
to
dd08d2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #909 +/- ##
======================================
Coverage 73.8% 73.8%
======================================
Files 75 75
Lines 8485 8485
======================================
Hits 6264 6264
Misses 2221 2221 |
|
LGTM. |
dongahn
approved these changes
Feb 24, 2022
dongahn
added
the
merge-when-passing
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues seen recently in
t1006-qmanager-multiqueue.tandt1011-dynstate-change.tas discussed in issues #907 and #908.