Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a webhook for finalizing #1193

Open
cdlliuy opened this issue May 11, 2022 · 0 comments
Open

Add a webhook for finalizing #1193

cdlliuy opened this issue May 11, 2022 · 0 comments

Comments

@cdlliuy
Copy link
Contributor

cdlliuy commented May 11, 2022

Describe the feature

Flagger provides different kinds of webhooks to control the rollout process.

Besides all current webhooks, per our business requirement, we hope to have a webhook between Promotion and Finalizing steps.

In promotion step, flagger copies the canary deployment spec to primary.
In Finalizing step, flagger scales down the canary deployment.
Anyway, in between, we would like to a webhook to provide an approval before the "scale-down-to-zero" operation.

I will raise a PR to achieve this feature for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant