Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: knative serving support #92

Closed
polothy opened this issue Mar 8, 2019 · 2 comments
Closed

Question: knative serving support #92

polothy opened this issue Mar 8, 2019 · 2 comments

Comments

@polothy
Copy link

polothy commented Mar 8, 2019

Unsure if this question even makes sense, but would flagger be able to apply its canary magic to knative serving CRD? Maybe too much going on there since knative uses different autoscaling logic I think. Just curious if both could be used together or really should just stick with flagger and Istio/k8s features.

Really amazing project, love the feature set and how it rolls things out. We might try experimenting with it soon! Thanks!

@stefanprodan
Copy link
Member

stefanprodan commented Mar 10, 2019

Hi @polothy

I think Flagger could be integrated with Knative serving, it's not trivial work, but in theory it could be done. I don't know if it makes sense, since Knative has its own deployment strategy based on versioning.

My focus right now is to make Flagger work with different deployment patterns, like canaries with progressive traffic, A/B testing with session affinity and blue/green with e2e testing. Some of those deployment strategies are not suitable for FaaS.

If you try Flagger, please let me know how it went. Thanks!

@polothy
Copy link
Author

polothy commented Mar 11, 2019

I don't know if it makes sense, since Knative has its own deployment strategy based on versioning.

Yeah, it may not be a great fit, they are doing their own thing and it's probably risky trying to layer so many projects.

I like the priorities you mentioned!

Thanks for the reply, I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants