Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper FS root is set while bootstrapping #2764

Merged
merged 1 commit into from
May 24, 2022

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented May 24, 2022

Addresses #1522 (comment)

Fixes #2757

@hiddeco hiddeco force-pushed the fix-rel-paths-custom-bootstrap branch from ad22030 to e900772 Compare May 24, 2022 10:11
@hiddeco hiddeco added bug Something isn't working area/bootstrap Bootstrap related issues and pull requests area/kustomization Kustomization related issues and pull requests labels May 24, 2022
@hiddeco hiddeco force-pushed the fix-rel-paths-custom-bootstrap branch from e900772 to 1b9d474 Compare May 24, 2022 10:12
This ensures relative paths to e.g. bases can be used.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco force-pushed the fix-rel-paths-custom-bootstrap branch from 1b9d474 to 5130a15 Compare May 24, 2022 10:14
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @hiddeco 🏅

@hiddeco hiddeco merged commit 8c5d83d into main May 24, 2022
@hiddeco hiddeco deleted the fix-rel-paths-custom-bootstrap branch May 24, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bootstrap Bootstrap related issues and pull requests area/kustomization Kustomization related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants